Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Don't print an error when gracefully quiting rill project logs --follow #5926

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CLI: Don't print an error when gracefully quiting rill project logs --follow #5926

wants to merge 2 commits into from

Conversation

begelundmuller
Copy link
Contributor

No description provided.

@begelundmuller begelundmuller self-assigned this Oct 17, 2024
pjain1
pjain1 reviewed Oct 17, 2024
View reviewed changes
cli/cmd/project/logs.go

ctx, cancel := context.WithCancel(cmd.Context())
ctx, cancel := context.WithCancelCause(cmd.Context())
defer cancel(nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed or just good practice ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjain1 pjain1 pjain1 approved these changes

Assignees

@begelundmuller begelundmuller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@begelundmuller @pjain1