capabilities: fix assignment to default value of non-standard DotvvmP… #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasherceg
approved these changes
Oct 4, 2024
|
Please fix the tests. |
exyi
force-pushed
the
fix-capabilities-setdefault
branch
from
49c295e
to
64992dd
Compare
…roperty There was an inverted condition when compared to SetValueDirect. In most cases, SetValueDirect is used, except when the property is a DotvvmProperty with overriden GetValue/SetValue or is inherited
exyi
force-pushed
the
fix-capabilities-setdefault
branch
from
64992dd
to
69244c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roperty
There was an inverted condition when compared to SetValueDirect. In most cases, SetValueDirect is used, except when the property is a DotvvmProperty with overriden GetValue/SetValue or is inherited