-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-release updates #441
Open
atenart
wants to merge
10
commits into
main
Choose a base branch
from
at/updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pre-release updates #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atenart
force-pushed
the
at/updates
branch
6 times, most recently
from
November 28, 2024 17:01
ae12b77
to
f658cf8
Compare
Signed-off-by: Antoine Tenart <[email protected]>
'pyo3' is listed as an extra feature dependency to the 'python' one. However retis-event does not have a 'pyo3' feature. It's not a way to select the 'pyo3' crate either as this is done in the 'python-embed' and 'python-lib' features. The 'python' feature is just an underlying one for shared behavior between the other more specialize Python features. Remove it. Signed-off-by: Antoine Tenart <[email protected]>
Signed-off-by: Antoine Tenart <[email protected]>
Signed-off-by: Antoine Tenart <[email protected]>
Lots of API changes as described here, https://pyo3.rs/v0.23.0/migration.html Signed-off-by: Antoine Tenart <[email protected]>
For now keep rust-pcap 1.3. Signed-off-by: Antoine Tenart <[email protected]>
- Downgrade cargo-platform. - Downgrade the Cargo.lock version. Signed-off-by: Antoine Tenart <[email protected]>
Data inside complex enums can't be directly accessed in the Python representation of the events. The only way was to use the dict representation, which prevents from using the event fields directly. This made the enum fields to stand out, including the whole OvS event. Instead do a little dance with serde and allow in Python things like: print(e['skb'].ip.version.v6.flow_label) This does not change the JSON representation. Closes #437. Suggested-by: Adrian Moreno <[email protected]> Signed-off-by: Antoine Tenart <[email protected]>
A new macro, BINDGEN_DEF, is introduced to avoid having to define those constants twice. It provides a transparent way to define a constant value which can be shared between eBPF and Rust through bindgen. Signed-off-by: Antoine Tenart <[email protected]>
Signed-off-by: Antoine Tenart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the upgrade to a newer version of
libbpf/-sys/-rs
now that the upstream fix is in the latest release.Also update
pyo3
to its latest version, which comes with multiple API changes.