WIP: Move core typedefs out of Js modules

[cknitt]

No description provided.

[cknitt]

The approach in this PR works fine for me. As mentioned, I had issues when putting the typedefs directly into the individual Core modules, see #7126 (comment).

Done so far for date and regExp, shall I continue this way for the other types @cristianoc @zth ?

[cristianoc]

The approach in this PR works fine for me. As mentioned, I had issues when putting the typedefs directly into the individual Core modules, see #7126 (comment).

Done so far for date and regExp, shall I continue this way for the other types @cristianoc @zth ?

The questions is what we want to expose to the user when hovering. @zth ?

[cknitt]

The questions is what we want to expose to the user when hovering. @zth ?

@cristianoc @zth Hover would currently look like this:

[zth]

Probably something we'll have to make look artificially better in the editor tooling anyway. So I'm fine with this.

Ideally from my POV, the first hover should just be date and not include type Pervasives.date = CoreTypes.date. And the second one just be Type Date.t = date. So, in other words, always hide CoreTypes and Pervasives. Half baked though maybe, but that's what I think at a glance.

[cristianoc]

We can separately think about what is the ideal way of expressing a type.
And the editor should nudge towards that way.

Btw gentype currently has the issue that work worse for code included in the compiler than for user code. (When looking for where a type is defined, as well as shipping .tsx files).
This will be addressed when it is revamped. And for now it's necessary to hard code all the possible paths as in this PR.

Let's go with this.