Fix exception rethrow #6933
Open
Fix exception rethrow #6933
+647
−1,008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DZakh
commented
Aug 4, 2024
| throw new Error(exn.RE_EXN_ID, { | ||
| cause: exn | ||
| }); | ||
| throw exn; |
There was a problem hiding this comment.
It should throw raw_exn instead
jscomp/test/equal_exception_test.js
Outdated
Comment on lines
94
to
97
| catch (raw_exn){ | ||
| let exn = Caml_js_exceptions.internalToOCamlException(raw_exn); | ||
| if (exn.RE_EXN_ID === A) { | ||
| if (exn._1 === 3) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I see it worth renaming to:
Suggested change
| catch (raw_exn){ | |
| let exn = Caml_js_exceptions.internalToOCamlException(raw_exn); | |
| if (exn.RE_EXN_ID === A) { | |
| if (exn._1 === 3) { | |
| return; | |
| } | |
| catch (exn) { | |
| let exnCause = Caml_js_exceptions.internalExnToCause(exn); | |
| if (exnCause.RE_EXN_ID === A) { | |
| if (exnCause._1 === 3) { | |
| return; | |
| } | |
| throw exn |
jscomp/test/equal_exception_test.js
Outdated
| _1: 3 | ||
| }; |
There was a problem hiding this comment.
This should be generated as new Error("A", { cause: {...} }) instead
This was referenced Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6929