Truncate overly long suggest fields before persisting them
#563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `constraint` field from the `organization_package_link` table is limited to 255 chars. Currently, synchronization fails for packages that use `suggest` fields longer than 255 chars, and it becomes impossible to manage them from the UI (even if only to remove them).
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
============================================
- Coverage 99.21% 99.20% -0.02%
- Complexity 1893 1894 +1
============================================
Files 301 301
Lines 6014 6016 +2
============================================
+ Hits 5967 5968 +1
- Misses 47 48 +1
Continue to review full report at Codecov.
|
|
Truncated description is not a problem ? We can maybe change type in database in order to allow longest text ? And manage length in UI ? (css, ellipsis or something else) |
|
agree with @alamirault, you'd better change the field type to text :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
constraintfield from theorganization_package_linktable is limited to 255 chars.Currently, synchronization fails for packages that use
suggestfields longer than 255 chars, and it becomes impossible to manage them from the UI (even if only to remove them).Note that I am open to suggestions on how we might otherwise handle these cases.