Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schedule): replace later with cron #32718

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(schedule): replace later with cron #32718

wants to merge 9 commits into from
+44 −37

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Nov 25, 2024 •
edited by viceice
Loading

Changes

Replace all later scheduleing in docs & presets with their cron equivalent

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes Nov 25, 2024
View reviewed changes
viceice
viceice reviewed Nov 25, 2024
View reviewed changes
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/key-concepts/scheduling.md Outdated Show resolved Hide resolved
docs/usage/noise-reduction.md Show resolved Hide resolved
docs/usage/noise-reduction.md Show resolved Hide resolved
lib/config/presets/internal/schedule.ts Show resolved Hide resolved
@viceice viceice changed the title refactor(schedule): replace later with cron feat(schedule): replace later with cron Nov 25, 2024
@RahulGautamSingh
Copy link
Collaborator Author

Ranges are inclusive.
For example, 8-11 for an 'hours' entry specifies execution at hours 8, 9, 10, and 11.

@RahulGautamSingh RahulGautamSingh mentioned this pull request Nov 26, 2024
Merged
6 tasks
@RahulGautamSingh

This comment was marked as outdated.

Sign in to view
viceice
viceice reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see new comments

viceice
viceice reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the mentioned descriptions for better copying as discussed on slack

viceice
viceice reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins do you prefer zero or seven for sunday? we should be consistent and only use one of them even both are working.

docs/usage/key-concepts/scheduling.md
"every weekend"
]
"description": "Schedule during typical non-office hours on weekdays (i.e., 10 PM - 5 AM) and anytime on weekends",
"schedule": ["* 0-4,22-23 * * 1-5", "* * * * 6,7"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"schedule": ["* 0-4,22-23 * * 1-5", "* * * * 6,7"]
"schedule": ["* 0-4,22-23 * * 1-5", "* * * * 0,6"]

we should consistently use 0,6 or 6,7

docs/usage/key-concepts/scheduling.md
"matchPackageNames": ["aws-sdk"],
"schedule": ["after 9pm on sunday"]
"schedule": ["* 21-23 * * 7"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"schedule": ["* 21-23 * * 7"]
"schedule": ["* 21-23 * * 0"]

@HonkingGoose
Copy link
Collaborator

I agree that we should be consistent with the times, if possible. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice left review comments

@HonkingGoose HonkingGoose Awaiting requested review from HonkingGoose

@rarkins rarkins Awaiting requested review from rarkins

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Widen cron syntax support, update docs
4 participants
@RahulGautamSingh @HonkingGoose @viceice @rarkins