Problematic Zod schema #4413
Open
Problematic Zod schema #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
avanderbergh
commented
Oct 17, 2024
Comment on lines
+20
to
+22
| return ( | ||
| (def as z.ZodNumberDef).checks.find((c) => c.kind === 'min')?.value ?? 0 | ||
| ); |
There was a problem hiding this comment.
@JonnyBurger This fixes this particular issue with the min() or gte(). Would it make sense to also cover other checks like gt() and positive(), multipleOf(), etc...?
And then would it make sense to also extend the same method to other types like string and BigInt for example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4157
In the case where a
mincheck exists on aNumbertype, we use that value instead of0.