-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pydantic Model for pr_info
, pr_json
, and versions
#2265
Conversation
pr_info
and pr_json
pr_info
, pr_json
, and versions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2265 +/- ##
==========================================
- Coverage 71.44% 71.09% -0.36%
==========================================
Files 99 97 -2
Lines 9838 9639 -199
==========================================
- Hits 7029 6853 -176
+ Misses 2809 2786 -23 ☔ View full report in Codecov by Sentry. |
cbf8816
to
9483ae9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all functional changes from this PR. We are more than happy to accept them in other PRs, but it makes it hard to read the diff. Let's only do typing and pydantic models here.
047bf1e
to
8091476
Compare
@beckermr Also, any clue why pydantic is not found in the CI? It's part of the environment |
you need to regenerate the lock file I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions.
Why does regenerating the lock file with |
Yeah it is annoying. It turns out conda-lock itself doesn't produce lock files with nice diffs. I ended up writing some custom code in https://github.com/regro/cf-scripts/blob/master/autotick-bot/relock_me.py that produces stable, sorted lock files that have much smaller diffs. I'm ok merging the changes here, but we could run the latest lock file through the function in that script to make them cleaner. I should upstream that bit of code to conda lock, but have not had the time. If you want to do that, great, but no pressure from me. I know you are busy. |
Closing and reopening to cycle the ci |
I think the CI is not working because of the lock file conflicts. |
pre-commit.ci autofix |
@ytausch one more issue to be resolved on smithy version validation and then this one is good to go. |
Extending #2239, this PR adds documenting Pydantic models for the
pr_info
,pr_json
, andversions
JSON collections.#2239 should be merged first.