-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default ClientOptions.timeoutOptions to TimeoutOptions.enabled() #2927
Conversation
Hey @thachlp , there is a number of tests that fail after this change, most likely because they do not expect these timeout options to be set by default. Could you address this? |
Let me check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Right now this fix is targeted for 7.x, I'll discuss this in the team and see if we should merge it to a 7.x branch or change the target version. I am personally leaning for changing the target branch.
Thanks @tishun |
Issue #2518
Make sure that:
mvn formatter:format
target. Don’t submit any formatting related changes.