Adds StorageClusterPeer annotation to client pair mapping #244
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vbnrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.18 |
|
@vbnrh: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
controllers/utils/configmap.go
Outdated
| ODFInfoConfigMapName = "odf-info" | ||
| ConfigMapResourceType = "ConfigMap" | ||
| ClientInfoConfigMapName = "odf-client-info" | ||
| StorageClusterPeerNameAnnotationKey = "ocs.openshift.io/storage-cluster-peer-ref" |
There was a problem hiding this comment.
@nb-ohad can you please take a look at the annotation name?
There was a problem hiding this comment.
Would prefer to call it
| StorageClusterPeerNameAnnotationKey = "ocs.openshift.io/storage-cluster-peer-ref" | |
| StorageClusterPeeAnnotationKey = "ocs.openshift.io/storage-cluster-peer" |
Signed-off-by: vbadrina <[email protected]>
vbnrh
force-pushed
the
add-annotation-configmap
branch
from
5565db1 to
51291b1
Compare
|
verified the annotation name: |
openshift-merge-bot
bot
merged commit 190d5a5
into
red-hat-storage:main
|
@vbnrh: new pull request created: #246 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com/browse/DFBUGS-964