Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixed] Prevent unintended register and unregister #808 #1040

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fixed] Prevent unintended register and unregister #808 #1040

wants to merge 1 commit into from

Commits on Feb 13, 2024

  1. [fixed] Prevent unintended register and unregister 

    - Fixed [reactjs#808](reactjs#808)
- Checking `this.props.isOpen` instead of `this.state.isOpen` in `componentWillUnmount`.
- Moved the call to `this.beforeOpen()` from the beginning of the `open` method to an else block.
- Set `this.closeTimer` without waiting until the end of the setState.
- Call `this.afterClose()` directly after setting the state in `closeWithoutTimeout`.
    @honeymaro
    honeymaro committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    ea5aaf0 View commit details
    Browse the repository at this point in the history