Show pod list with IPs when getting clusters in client #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryge00
changed the title
harryge00
force-pushed
the
getcluster-cli
branch
2 times, most recently
from
b9d20e0
to
512241a
Compare
|
@harryge00 Is it ok to tag this change to v0.4.0 release? |
Of course. It's ok |
harryge00
force-pushed
the
getcluster-cli
branch
from
512241a
to
3cdc024
Compare
|
@harryge00 Could you rebase the master and I feel we can review and merge the code |
|
@harryge00 could we resolve the merge conflicts on this one? |
|
We should use a stale bot #681 In the meantime, @harryge00 @Jeffwan is there still interest in merging this? Otherwise, I'll close it in a week. |
|
Closing as "stale". Obviously, feel free to reopen or open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, in kuberay cli,
cluster getdoes not provide any more useful information thancluster list.In many cases, ray developer may not have the access to the kubernetes environment. After using kuberay client to create their ray clusters, the list of pods and ips are necessary for them to debug logs and ssh.
Related issue number
Checks