[Feature] Add ManagedBy field #2589
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszadkow
commented
Nov 29, 2024
| // the field value is the reserved string 'ray.io/kuberay-operator', | ||
| // but delegates reconciling the RayJob with 'kueue.x-k8s.io/multikueue' to the Kueue. | ||
| // The field is immutable. | ||
| // TBD: Immutability from k8s v1.28 and above, below it won't be - is this acceptable? |
There was a problem hiding this comment.
@andrewsykim @kevin85421 question to you, as we can enforce immutability with CEL Validation, but only from k8s v1.25 (since it's beta).
E.g kuberay kind version is v1.25.3, so I wonder how much impact it can have
|
/assign @mimowo |
mszadkow
force-pushed
the
feature/add-managed-by-field
branch
from
e008eec
to
6849598
Compare
mimowo
reviewed
Nov 29, 2024
| return nil | ||
| } | ||
|
|
||
| var validManagedBy = sets.NewString( |
There was a problem hiding this comment.
I would suggest to use New[string] and move the block to the top of the file
Comment on lines
+876
to
+880
| if managedBy != nil { | ||
| if !validManagedBy.Has(*managedBy) { | ||
| return field.NotSupported(field.NewPath("spec").Child("managedBy"), *managedBy, validManagedBy.List()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| if managedBy != nil { | |
| if !validManagedBy.Has(*managedBy) { | |
| return field.NotSupported(field.NewPath("spec").Child("managedBy"), *managedBy, validManagedBy.List()) | |
| } | |
| } | |
| if managedBy != nil && !validManagedBy.Has(*managedBy) { | |
| return field.NotSupported(field.NewPath("spec").Child("managedBy"), *managedBy, validManagedBy.List()) | |
| } |
Comment on lines
+849
to
+851
| if err := validateManagedBy(rayJob.Spec.ManagedBy); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Actually, I think this validation could now be moved to CEL. cc @andrewsykim @kevin85421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
As stated in #2544.
It allows for integration with MultiKueue (multi-cluster Kueue), in specific it provides:
Related issue number
Relates to #2544
Checks