Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodeSelector for apiserver #2556

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pengliangml
Copy link

@pengliangml pengliangml commented Nov 20, 2024

Why are these changes needed?

We utilize the combinations of tolerances and nodeSelector to manage which nodes the computing pods would be assigned to. And we also have the apiserver for access control, so it's important to support nodeSelector for apiserver. Could you kindly review and merge this PR? Thanks!

Related issue number

None

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@pengliangml
Copy link
Author

@kevin85421

@kevin85421
Copy link
Member

cc @YQ-Wang @han-steve would you mind reviewing this PR? Thanks!

Signed-off-by: pengliangml <[email protected]>
@blublinsky
Copy link
Contributor

This seems like a duplicate of #2523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants