[Name Cast]: Don't attempt to store computed columns to the database (#…

…12)

src/Casts/NameCast.php

@@ -18,7 +18,9 @@ public function __construct(protected ?string $firstName = null, protected ?stri
 
     public function get($model, string $key, $value, array $attributes): Name
     {
-        if ($value) {
+        // We're probably dealing with a single column instead of a combination
+        // of two columns.
+        if (Arr::has($attributes, $key)) {
             return Name::from($value);
         }
 
@@ -28,8 +30,17 @@ public function get($model, string $key, $value, array $attributes): Name
         return Name::from("{$firstName} {$lastName}");
     }
 
-    public function set($model, string $key, $value, array $attributes): string
+    public function set($model, string $key, $value, array $attributes): array
     {
-        return (string) $value;
+        // We're probably dealing with a single column instead of a combination
+        // of two columns.
+        if (! $value instanceof Name) {
+            return [$key => $value];
+        }
+
+        return [
+            $this->firstName => $value->first,
+            $this->lastName => $value->last,
+        ];
     }
 }

tests/Feature/NameCastTest.php

@@ -12,7 +12,9 @@
         ->and($model->name->first)->toBe('John')
         ->and($model->name->last)->toBe('Smith')
         ->and($model->name->full)->toBe('John Smith')
-        ->and((string) $model->name)->toBe('John Smith');
+        ->and((string) $model->name)->toBe('John Smith')
+        ->and($model->getDirty())->toHaveKey('name')
+        ->and($model->getDirty()['name'])->toBe('John Smith');
 });
 
 it('can be casted from first and last name on a model', function () {
@@ -30,3 +32,13 @@
         ->and($model->custom_name->first)->toBe('John')
         ->and($model->custom_name->last)->toBe('Smith');
 });
+
+it('will not attempt to store a computed column to the database if it is accessed before saving the model', function () {
+    $model = new Model(['given_name' => 'John', 'family_name' => 'Smith']);
+
+    $model->custom_name;
+
+    expect($model->getDirty())->not->toHaveKey('custom_name')
+        ->toHaveKey('given_name')
+        ->toHaveKey('family_name');
+});