Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dbQuoteLiteral() uses exponential notation for numeric values #471

Merged
merged 1 commit into from
May 1, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Apr 1, 2024

Closes #404.

Copy link
Contributor

aviator-app bot commented Apr 1, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@aviator-app aviator-app bot added the blocked label Apr 1, 2024
Copy link
Contributor

aviator-app bot commented Apr 1, 2024

This pull request failed to merge: some CI status(es) failed. Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Failed CI(s): Smoke test: stock R

@krlmlr krlmlr force-pushed the b-404-quote-double branch from 3422ef1 to 26d3317 Compare April 1, 2024 17:16
@krlmlr krlmlr removed the blocked label Apr 1, 2024
@aviator-app aviator-app bot added the blocked label Apr 1, 2024
Copy link
Contributor

aviator-app bot commented Apr 1, 2024

This pull request failed to merge: some CI status(es) failed. Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Failed CI(s): Smoke test: stock R

@krlmlr krlmlr force-pushed the b-404-quote-double branch from 26d3317 to af07890 Compare April 1, 2024 17:23
@krlmlr krlmlr force-pushed the b-404-quote-double branch from af07890 to c09da62 Compare May 1, 2024 17:36
@krlmlr krlmlr removed the blocked label May 1, 2024
@aviator-app aviator-app bot added the blocked label May 1, 2024
Copy link
Contributor

aviator-app bot commented May 1, 2024

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

@krlmlr krlmlr removed the blocked label May 1, 2024
@aviator-app aviator-app bot force-pushed the b-404-quote-double branch from c09da62 to 180feb2 Compare May 1, 2024 21:21
@aviator-app aviator-app bot merged commit 9d2e604 into main May 1, 2024
15 of 16 checks passed
@aviator-app aviator-app bot deleted the b-404-quote-double branch May 1, 2024 23:21
krlmlr added a commit that referenced this pull request Jun 2, 2024
This reverts commit 9d2e604, reversing
changes made to cb5235a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbQuoteLiteral() for numerics has insufficient precision in some cases
1 participant