Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in NotificationCenter+Utils #16

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

alemannosara
Copy link
Contributor

The library includes compile-time warning: Non-'@objc' instance method in extensions cannot be overridden; use 'public' instead.
This PR aims at resolving these warnings by using public instead of open for the methods in question.

Copy link

@noefroidevaux noefroidevaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!! 🤩👍

@alemannosara alemannosara merged commit 1b35a0c into master Jan 17, 2024
2 checks passed
@alemannosara alemannosara deleted the fix-warnings-in-NotificationCenter+Utils branch January 17, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants