Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .pylintrc to match qiskit-terra's current version #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

garrison
Copy link
Member

Summary

The current .pylintrc is a bit out of date with those used throughout the Qiskit ecosystem. This PR updates it to the latest version used by Qiskit Terra. There are some variations among other qiskit-related projects (e.g. the applications modules), but I think starting users out with the Terra configuration is a reasonable default.

Details and comments

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2496705474

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2432022428: 0.0%
Covered Lines: 14
Relevant Lines: 14

💛 - Coveralls

@garrison
Copy link
Member Author

Turns out, qiskit-terra is also currently pinned to pylint 2.8.3. So this approach of copying the file verbatim may not work here. I might just remove the few offending options from .pylintrc (see below, from CI) and call it a day.

************* Module /home/runner/work/quantum-prototype-template/quantum-prototype-template/.pylintrc
.pylintrc:1:0: E0015: Unrecognized option found: files-output, module-name-hint, const-name-hint, class-name-hint, function-name-hint, method-name-hint, attr-name-hint, argument-name-hint, variable-name-hint, class-attribute-name-hint, inlinevar-name-hint, no-space-check (unrecognized-option)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'no-self-use' (unknown-option-value)
.pylintrc:1:0: R0022: Useless option value for '--disable', 'bad-continuation' was removed from pylint, see https://github.com/PyCQA/pylint/pull/3571. (useless-option-value)
.pylintrc:1:0: R0022: Useless option value for '--disable', 'bad-whitespace' was removed from pylint, see https://github.com/PyCQA/pylint/pull/3577. (useless-option-value)
ERROR: InvocationError for command /home/runner/work/quantum-prototype-template/quantum-prototype-template/.tox/lint/bin/nbqa pylint -rn docs/ (exited with code 14)
___________________________________ summary ____________________________________
ERROR:   lint: commands failed
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants