-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MPS and GZ support in translators
#583
Open
dthuerck
wants to merge
24
commits into
qiskit-community:main
Choose a base branch
from
dthuerck:mps-gz-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 20 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
41cb93c
Initial support fro reading/writing mps and gz files.
b45438f
Ran black.
6f6db0b
Ran tox; added unit test.
7077fbc
Make mps tests optional; support for 3.8.
60abd5f
Fix spelling.
0779c55
Ran black.
81977fe
Changing imports for linter.
6a69aec
Added fixes for gzip reading and tests.
7d40120
Fixing mypy.
d64866a
Add missing mode specifiers.
6291712
Manual management of tmp-file for Windows.
03fea8e
Deleted files that were accidentally pushed.
aaa88a9
Moving mps/lp IO functions into translators.
e45be75
Fix tests.
caf8ec9
Fix export in Tutorial 11.
f9e418c
Re-ran tutorial; added deprecation notes.
2b44785
Added a release note.
c489369
Updated copyright.
d144144
Merge branch 'main' into mps-gz-support
dthuerck 3345d7c
Merge branch 'main' into mps-gz-support
woodsp-ibm ae1d6ea
Added file_io to documentation, corrected dates.
10218e0
Adding tests for deprecated functions.
c26009a
Merge branch 'qiskit-community:main' into mps-gz-support
dthuerck dba2d54
Bump year.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include these in the documentation as they are public methods we now expect a user to use. You can see the pre-existing list above in the docstring - maybe it makes sense to have another section that lists these - or perhaps the export ones go under Translators there and the others under "File loading and saving" ?
You can see what the current page looks like from here https://qiskit-community.github.io/qiskit-optimization/apidocs/qiskit_optimization.translators.html. To build docs locally run
make html
in the project root, ormake clean html
which will wipe away whats there which sometimes is needed if the incremental build does not come out as expected - I find this more if I change the structure. One or more docstrings changed is pretty much ok. html will be in the _build folder that is created under docsIf you want to see how the docs come out in the build, if you go to build Details and Summary you can scroll down and see artifacts that the build creates.
documentation
is the docs built without running the tutorials as a quicker check.tutorials_3.x
are jobs under that version of Python that also build the docs but run the notebooks too.