-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rabi and chevron fixes #961
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
==========================================
- Coverage 97.58% 97.49% -0.09%
==========================================
Files 118 118
Lines 9057 9057
==========================================
- Hits 8838 8830 -8
- Misses 219 227 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the code and seems fine. I didn't test on hardware myself, but I saw you did, so I just trust the results in the OP
Closes #957 and #956 (comment)
For Rabis I just made the bounds a bit larger and change some initial conditions.
For Chevron I did a small refactor of the fit in order to take no longer the FFT but the row where there are more oscillations.
I've tested both and they seems to work as expected.
Checklist:
master
main
main