Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rabi and chevron fixes #961

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Rabi and chevron fixes #961

merged 3 commits into from
Aug 12, 2024

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Aug 1, 2024

Closes #957 and #956 (comment)
For Rabis I just made the bounds a bit larger and change some initial conditions.
For Chevron I did a small refactor of the fit in order to take no longer the FFT but the row where there are more oscillations.
image

I've tested both and they seems to work as expected.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@andrea-pasquale andrea-pasquale self-assigned this Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (6961ed1) to head (f8e36a0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   97.58%   97.49%   -0.09%     
==========================================
  Files         118      118              
  Lines        9057     9057              
==========================================
- Hits         8838     8830       -8     
- Misses        219      227       +8     
Flag Coverage Δ
unittests 97.49% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/protocols/coherence/spin_echo.py 100.00% <100.00%> (ø)
src/qibocal/protocols/rabi/amplitude.py 96.87% <100.00%> (ø)
src/qibocal/protocols/rabi/amplitude_signal.py 97.46% <100.00%> (ø)
src/qibocal/protocols/rabi/utils.py 100.00% <ø> (ø)
...protocols/two_qubit_interaction/chevron/chevron.py 96.96% <ø> (-2.28%) ⬇️
...c/qibocal/protocols/two_qubit_interaction/utils.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@Jacfomg Jacfomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecandido alecandido linked an issue Aug 2, 2024 that may be closed by this pull request
@andrea-pasquale andrea-pasquale linked an issue Aug 12, 2024 that may be closed by this pull request
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the code and seems fine. I didn't test on hardware myself, but I saw you did, so I just trust the results in the OP

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Aug 12, 2024
@andrea-pasquale andrea-pasquale added this to the Qibocal 0.0.11 milestone Aug 12, 2024
Merged via the queue into main with commit 4350b94 Aug 12, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix_rabi branch August 12, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants