QLockFile instead of QLockedFile

[sakgoyal]

This code seems weird to have as I believe it is based on qt4. I came across the built in qt version in the docs, but the interface is NOT the same.

Using the qt provided version would be better right?

or is the locking mode that necessary to the functionality?

you can also get the source here:
https://github.com/qt/qtbase/tree/dev/src/corelib/io

I could also just copy in the current qt version and add the locking modes myself. Let me know what is preferred.

This does seem to introduce breaking changes. I am not sure what effects this will have because I am not sure how to test the change

[glassez]

@sakgoyal
Why would you want to interfere with something that works without problems? Especially if you can't even test it:

I am not sure what effects this will have because I am not sure how to test the change

[xavier2k6]

This does seem to introduce breaking changes.

Well, let's see how our CI behaves for an indication!

[sakgoyal]

Why would you want to interfere with something that works without problems?

because I believe that code that qt provides (and updates regularly) is going to be more secure/battle tested than a custom implementation implementation from 2013 that does not get updated. (the legal notice from qt still says 2013)

Well, let's see how our CI behaves for an indication!

it compiles fine. and CI didnt complain either. but the logic has changed so I dont know what the effects of it are. (you no longer have the option to write-only or read-only lock)

[Chocobo1]

it compiles fine. and CI didnt complain either. but the logic has changed so I dont know what the effects of it are. (you no longer have the option to write-only or read-only lock)

It would be insane to approve such changes when nobody knows whether it will break the app logic or not. Then what is the point of such PR? To be honest, I'm inclined to just reject it.

[glassez]

because I believe that code that qt provides (and updates regularly) is going to be more secure/battle tested than a custom implementation

It isn't "custom implementation". It was borrowed from Qt a long time ago. In fact, it was even used by Qt itself in QtCreator until recently. But now it looks like they are using QLockFile.

PS. We could learn from their experience and borrow current implementation of QtLocalPeer.

[sakgoyal]

PS. We could learn from their experience and borrow current implementation of QtLocalPeer

where is it currently implemented? I could not find a reference to it anywhere.

[xavier2k6]

https://doc.qt.io/qt-6/qlockfile.html

[sakgoyal]

@xavier2k6 I was asking about the implementation for QtLocalPeer, not QLockFile.

[xavier2k6]

I was asking about the implementation for QtLocalPeer, not QLockFile

I know, I was only putting link there for quick reference....