Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumPy: Various updates #564

Merged
merged 4 commits into from
Oct 31, 2019
Merged

NumPy: Various updates #564

merged 4 commits into from
Oct 31, 2019

Conversation

hroncok
Copy link
Member

@hroncok hroncok commented Oct 29, 2019

No description provided.

@hroncok hroncok changed the title NumPy: Typo in comment NumPy: Typo in comment, Czech adjectives, explicit int explanation Oct 29, 2019
Apologies for the large diff
@hroncok hroncok changed the title NumPy: Typo in comment, Czech adjectives, explicit int explanation NumPy: Various updates Oct 29, 2019
@hroncok
Copy link
Member Author

hroncok commented Oct 29, 2019

OK, this have started as a typo fix, and ended up by restarting the entire notebook.

I can later try to produce a nicer diff by emitting the image changes, as I don't believe they are important. However not today. Let me know if I shall.

Can be previewed at https://naucse.python.cz/2019/mipyt-zima/intro/numpy/

@hroncok hroncok requested a review from encukou October 29, 2019 23:15
@hroncok
Copy link
Member Author

hroncok commented Oct 29, 2019

Nota bene:

  • The example with 49.799999999999997 is now corrected to 49.8 by NumPy (or Python?). I've cheated and edited it back manually.
  • There is a new deprecation warning (The truth value of an empty array is ambiguous...). I've manually edited the warning not to include my venv path. Also, it seems like we miss some CSS styles for those.

@encukou
Copy link
Member

encukou commented Oct 31, 2019

Looks good! Thanks!
FWIW, I diffed using nbdiff, specifically:

$ nbdiff-web \
    <(git show master:lessons/intro/numpy/index.ipynb) \
    <(git show HEAD:lessons/intro/numpy/index.ipynb)

@encukou
Copy link
Member

encukou commented Oct 31, 2019

The issues you found don't look critical, but could you open issues for them?

@hroncok
Copy link
Member Author

hroncok commented Oct 31, 2019

pyvec/naucse#27

@hroncok
Copy link
Member Author

hroncok commented Oct 31, 2019

#565

@hroncok hroncok merged commit 6180733 into pyvec:master Oct 31, 2019
@hroncok hroncok deleted the numpytypo branch October 31, 2019 15:21
@encukou
Copy link
Member

encukou commented Oct 31, 2019

Thank you!

@hroncok
Copy link
Member Author

hroncok commented Oct 31, 2019

Thanks for the nbdiff-web tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants