Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create build_wheels_aarch64_linux.yml #1083

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Create build_wheels_aarch64_linux.yml #1083

merged 5 commits into from
Oct 16, 2024

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Oct 15, 2024

See #1082 and #1076

AO seems to mostly work fine with torch.compile support for ARM so might as well ship the binaries

Copy link

pytorch-bot bot commented Oct 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1083

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 874db1c with merge base 48bc81c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2024
@msaroufim
Copy link
Member Author

msaroufim commented Oct 16, 2024

@atalman do you know why the AARCH jobs here are running a dry-run? Do I need to merge this code to main to do binary validation? I checked the torchvision jobs FWIW and they don't seem to postprocess aarch64 binaries with anything special. So if this looks good mind stamping and I can merge and test?

The wheel looks fine

+ aws s3 cp --dryrun dist/torchao-0.7.0.dev20241015-cp39-cp39-linux_aarch64.whl s3://pytorch/whl/nightly/cu124/ --acl public-read
(dryrun) upload: dist/torchao-0.7.0.dev20241015-cp39-cp39-linux_aarch64.whl to s3://pytorch/whl/nightly/cu124/torchao-0.7.0.dev20241015-cp39-cp39-linux_aarch64.whl

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msaroufim msaroufim merged commit ce4822b into main Oct 16, 2024
22 checks passed
@msaroufim msaroufim deleted the msaroufim-patch-24 branch October 16, 2024 16:52
@msaroufim
Copy link
Member Author

Confirming this works when I tested it on my raspberry pi 5

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
(myvenv) marksaroufim@rpi5:~/Dev $ pip install --pre torchao --index-url https://download.pytorch.org/whl/nightly/cpu --force-reinstall
Looking in indexes: https://download.pytorch.org/whl/nightly/cpu, https://www.piwheels.org/simple
Collecting torchao
  Downloading https://download.pytorch.org/whl/nightly/cpu/torchao-0.7.0.dev20241017-cp311-cp311-linux_aarch64.whl (515 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 515.1/515.1 kB 584.4 kB/s eta 0:00:00
Installing collected packages: torchao
  Attempting uninstall: torchao
    Found existing installation: torchao 0.0.3
    Uninstalling torchao-0.0.3:
      Successfully uninstalled torchao-0.0.3
Successfully installed torchao-0.7.0.dev20241017
(myvenv) marksaroufim@rpi5:~/Dev $ python
Python 3.11.2 (main, Aug 26 2024, 07:20:54) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torchao
>>> $

@msaroufim msaroufim mentioned this pull request Oct 17, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants