[icalendar] Update to 6.1.* #13109
Open
[icalendar] Update to 6.1.* #13109
+265
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
|
||
| class UIDGenerator: | ||
| chars: Final[list[str]] | ||
| @staticmethod | ||
| def rnd_string(length: int = 16) -> str: ... | ||
| @staticmethod | ||
| def uid(host_name: str = "example.com", unique: str = "") -> vText: ... | ||
|
|
||
| def is_date(dt: datetime.date) -> TypeIs[datetime.date]: ... # and not datetime.date |
There was a problem hiding this comment.
Suggested change
| def is_date(dt: datetime.date) -> TypeIs[datetime.date]: ... # and not datetime.date | |
| def is_date(dt: datetime.date) -> TypeIs[datetime.date]: ... # and not datetime.datetime |
There was a problem hiding this comment.
Also I think using TypeIs is inaccurate here. If it returns TypeIs[date], it should return True for all arguments that are instances of date, which this one doesn't. We could use TypeGuard, but given the parameter annotation, it can't really do useful narrowing anyway, so I'd just use bool as the return type.
| def is_datetime(dt: datetime.date) -> TypeIs[datetime.datetime]: ... | ||
| def to_datetime(dt: datetime.date) -> datetime.datetime: ... | ||
| def is_pytz(tz: datetime.tzinfo) -> TypeIs[BaseTzInfo]: ... | ||
| def is_pytz_dt(dt: datetime.date) -> TypeIs[datetime.datetime]: ... # and dt.tzinfo is BaseTZInfo |
There was a problem hiding this comment.
Should probably use TypeGuard here because of the extra condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13071