gh-127124: Change context watcher callback to a callable object #127247
+199
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables developers to associate state with the callback without relying on globals. Also, refactor the tests for improved readability and extensibility, and to cover the new state object.
rhansen
commented
Nov 25, 2024
| @@ -242,7 +242,7 @@ struct _is { | |||
| PyObject *audit_hooks; | |||
| PyType_WatchCallback type_watchers[TYPE_MAX_WATCHERS]; | |||
| PyCode_WatchCallback code_watchers[CODE_MAX_WATCHERS]; | |||
| PyContext_WatchCallback context_watchers[CONTEXT_MAX_WATCHERS]; | |||
| PyObject *context_watchers[CONTEXT_MAX_WATCHERS]; | |||
There was a problem hiding this comment.
Does this need a Py_VISIT somewhere? I didn't see any for the other fields in this struct, but maybe the GC does something special with this struct?
rhansen
commented
Nov 25, 2024
Comment on lines
+106
to
+112
| Registers the callable object *callback* as a context object watcher for the | ||
| current interpreter. When a context event occurs, *callback* is called with | ||
| two arguments: | ||
|
|
||
| #. An event type ID from :c:type:`PyContextEvent`. | ||
| #. An object containing event-specific supplemental data; see | ||
| :c:type:`PyContextEvent` for details. |
There was a problem hiding this comment.
I think my preference would be to create a new contextvars.ContextSwitchedEvent class that holds the Context object and pass that instead, but this is a smaller change.
|
I think that I would prefer to add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables developers to associate state with the callback without relying on globals.
Also, refactor the tests for improved readability and extensibility, and to cover the new state object.
This PR is an alternative to #127140.
This PR also incorporates #124741 because I don't think it makes sense to call a callable object without backing up the exception state first.
📚 Documentation preview 📚: https://cpython-previews--127247.org.readthedocs.build/