Generate __version__ at build to avoid slow importlib.metadata
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
approved these changes
Oct 11, 2024
|
I don't want to step in front of the steamroller of progress here, but what is this heavy |
|
Yep, |
AA-Turner
approved these changes
Oct 11, 2024
| @@ -42,6 +42,9 @@ scripts.blurb = "blurb.blurb:main" | |||
| [tool.hatch] | |||
| version.source = "vcs" | |||
|
|
|||
| [tool.hatch.build.hooks.vcs] | |||
| version-file = "src/blurb/_version.py" | |||
There was a problem hiding this comment.
Do these two lines tell hatch to automatically create the _version.py file that contains __version__ = '...' on build?
There was a problem hiding this comment.
That's right: https://github.com/ofek/hatch-vcs#build-hook-options
ezio-melotti
approved these changes
Oct 11, 2024
hugovk
changed the title
__version__ at build to avoid slow importlib.metadata import__version__ at build to avoid slow importlib.metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importlib.metadatais quite a heavy library to import, and can make CLI use less snappy.It's only used for fetching the version, and we can pre-generate it as part of our regular build instead.
Before
After