Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for keyword arguments passed to engines when opening a datatree #9283

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

JessicaS11
Copy link
Contributor

Our in-progress test development from SciPy 2024 sprints. Hoping to get back to finishing implementation of these tests, but happy for someone else to run with them too (let me know and I can give you access to this fork). Relevant to #8572, motivated by #9199, which solved a bug introduced in #9014.

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@TomNicholas TomNicholas added the topic-DataTree Related to the implementation of a DataTree class label Jul 26, 2024
@JessicaS11
Copy link
Contributor Author

I'm trying to get back into this and am realizing I don't have good notes on what our planned approach was. @eni-awowale, I think you were going to write some sort of test function for these keyword lists I'd started compiling - were you able to get to that? My current logic is that we simply need to make sure we can handle each of these potential keyword inputs, which just means passing each of them (one by one or collectively) into a test IO operation. That will require further formatting of these lists (perhaps into a single dict?), but beyond that I'd be happy for any suggestions on where to go next.

@eni-awowale
Copy link
Collaborator

Thanks @JessicaS11! I will take a look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-DataTree Related to the implementation of a DataTree class
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants