Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs on outputs #1401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated docs on outputs #1401

wants to merge 1 commit into from

Conversation

pierskarsenbarg
Copy link
Member

The previous version was technically correct in that you shouldn't create resources within an apply function but was incorrect that it is not allowed

The previous version was technically correct in that you shouldn't create resources within an apply function but was incorrect that it is not allowed
@pierskarsenbarg pierskarsenbarg requested a review from a team as a code owner August 6, 2024 10:22
Copy link
Contributor

@tgummerer tgummerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing this.

@@ -58,7 +58,7 @@ public interface Output<T> extends Copyable<Output<T>> {
* The result remains an {@link Output}{@literal <T>} so that dependent resources
* can be properly tracked.
* <p>
* {@code func} is not allowed to make resources.
* {@code func} hould not be used to create resources unless necessary. Creating resources within 'func' can cause unknown behaviour.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* {@code func} hould not be used to create resources unless necessary. Creating resources within 'func' can cause unknown behaviour.
* {@code func} should not be used to create resources unless necessary as `func` may not be run during some program executions.

Let's make it the same as in pulumi/pulumi#16885.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants