Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of actions hooks #1039

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Jul 12, 2024

Stacked on top of #1038

Related to #936

Remove arbitary code injection hooks.

This can only be merged once no providers are using these actions: https://github.com/search?q=org%3Apulumi+path%3A.ci-mgmt.yaml+%22actions%3A%22&type=code

- Prepare upstream if we're running tests via the provider module.
- Run `make upstream` before running any extra `setup-script`.
- Only run provider integration tests on PRs if we're in "local" mode and not "pulumiExamples".
- Format main test command to avoid confusing line break.
This addresses the use of the preTest hook in the docker provider.
@danielrbradley danielrbradley self-assigned this Jul 12, 2024
@danielrbradley danielrbradley changed the title Remove use of actions.preTest Remove use of actions Jul 12, 2024
@danielrbradley danielrbradley changed the title Remove use of actions Remove use of actions hooks Jul 12, 2024
@mjeffryes mjeffryes modified the milestone: 0.107 Jul 24, 2024
Base automatically changed from test-prepare-upstream to master July 24, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants