Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jquery-ui-rails #6358

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade jquery-ui-rails #6358

wants to merge 1 commit into from

Conversation

eliotjordan
Copy link
Member

Updates jquery-ui-rails to address 4 dependabot alterts.

Meta question for later: Are we still using all of the jquery-ui components? For example, I think we're using the Lux datepicker now.

@hackartisan
Copy link
Member

How do / can we know that everything using jquery-ui stills works after this merge?

@hackartisan
Copy link
Member

It looks like it's mostly used in the (old) structure manager.

@hackartisan
Copy link
Member

hackartisan commented Apr 23, 2024

I'm not sure it's working right? I just tried the structure manager on figgy-staging for this item: https://figgy-staging.princeton.edu/concern/scanned_resources/123bbbfb-4e7d-4bc6-9752-4b48925a1cdf/struct_manager

screenshot shows what it looks like after I drag / dropped a page
Screenshot 2024-04-23 at 4 45 56 PM

Copy link
Contributor

@tpendragon tpendragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old structure manager definitely breaks, and the nestedSortable plugin isn't updated for new jquery-ui. We'll have to delay this update until we remove the old structure editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants