Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialize method for Rails 7.1.2 compatibility #384

Closed
wants to merge 5 commits into from
+1 −1
Closed

Fix serialize method for Rails 7.1.2 compatibility #384

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b824bd5
feat: add coder to serialize
yhru Jan 4, 2024
6815d96
Update README.md
yhru Jan 8, 2024
3279bde
Update README.md
yhru Jan 9, 2024
ac1b428
Merge branch 'main' into main
yhru Jan 19, 2024
4791ab1
Update README.md
yhru Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ recorded activities to users - similarly to how GitHub does it.

## Rails 7

**As of version 2.0.0, public_activity also supports Rails up to 7.0.**
**As of version 2.0.0, public_activity also supports Rails up to 7.1.2**

## Table of contents

Expand Down
2 changes: 1 addition & 1 deletion lib/public_activity/orm/active_record/activity.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class Activity < ::ActiveRecord::Base
# Serialize parameters Hash
begin
if table_exists?
serialize :parameters, Hash unless %i[json jsonb hstore].include?(columns_hash['parameters'].type)
serialize :parameters, coder: YAML, type: Hash unless %i[json jsonb hstore].include?(columns_hash['parameters'].type)
else
warn("[WARN] table #{name} doesn't exist. Skipping PublicActivity::Activity#parameters's serialization")
end
Expand Down