Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sqlite fix and parser error #478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Darkbat91
Copy link

It was mentioned previously and I was looking to get SQLite support within the GRGSM monitor.

This just functionally changed the grgsm_scanner module too add a sqlite flag and a recursive flag. These mostly would be used at the same time but i did not think that they should be explicitly tied to each other.

I also found an error in the original code base whereby the options checks in the main function were calling an undefined parser object. argument parser is not ideal but i was not sure how else would fix it without creating another parser object or moving the validation into the argument_parser definition.

@Darkbat91
Copy link
Author

Darkbat91 commented Sep 9, 2019

CMake Error at CMakeLists.txt:150 (message):

  GnuRadio Runtime required to compile gr-gsm

Kali and Debian failed with the above error is this something to do with 3.8? I did not change anything in the build process, I can try to hunt down the error if necessary.

@velichkov
Copy link
Contributor

Hi @Darkbat91,

Thanks for this contribution.

It was mentioned previously and I was looking to get SQLite support within the GRGSM monitor.

For the record the previous SQLite issue is #466.

This just functionally changed the grgsm_scanner module too add a sqlite flag and a recursive flag. These mostly would be used at the same time but i did not think that they should be explicitly tied to each other.

I also found an error in the original code base whereby the options checks in the main function were calling an undefined parser object. argument parser is not ideal but i was not sure how else would fix it without creating another parser object or moving the validation into the argument_parser definition.

Will try to review it later this week.

CMake Error at CMakeLists.txt:150 (message):

  GnuRadio Runtime required to compile gr-gsm

Kali and Debian failed with the above error is this something to do with 3.8?

Yes, it is related to gnuradio 3.8. We are working on it in #475

I did not change anything in the build process, I can try to hunt down the error if necessary.

No need.

bkerler added a commit to bkerler/gr-gsm that referenced this pull request Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants