Timestamp support for const metrics #129
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lars Strojny <[email protected]>
Signed-off-by: Lars Strojny <[email protected]>
Signed-off-by: Lars Strojny <[email protected]>
|
@mxinden any thoughts? |
mxinden
reviewed
Feb 27, 2023
Comment on lines
+347
to
+350
| if let Ok(time) = timestamp.duration_since(UNIX_EPOCH) { | ||
| self.writer.write_char(' ')?; | ||
| return self.writer.write_str(&time.as_millis().to_string()); | ||
| } |
| fn write_timestamp(&mut self, timestamp: SystemTime) -> Result<(), std::fmt::Error> { | ||
| if let Ok(time) = timestamp.duration_since(UNIX_EPOCH) { | ||
| self.writer.write_char(' ')?; | ||
| return self.writer.write_str(&time.as_millis().to_string()); |
There was a problem hiding this comment.
This library follows the OpenMetrics specification. This should be compatible with recent Prometheus versions (remember to set the right content type).
Please use seconds instead of milliseconds here.
https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#timestamps-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mxinden could you have a look if this is roughly what you had in mind?
Addresses #126