Reduce vertical size of scan plot #953
Merged
+25
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argilo
commented
Dec 7, 2024
Comment on lines
+19
to
+21
| colors: { | ||
| Spectra: "#2f77b4" | ||
| }, |
There was a problem hiding this comment.
Removing the legend had the side effect of assigning colours to the datasets randomly, so I've explicitly defined them here.
argilo
commented
Dec 7, 2024
| @@ -1272,7 +1272,7 @@ | |||
| document.getElementById("main").style.marginLeft = "350px"; | |||
| document.getElementById("mySidenav").style.borderRadius = "0px 25px 25px 0px"; | |||
| mymap.invalidateSize(); | |||
| setTimeout(scan_chart_obj.resize,500); | |||
| scan_chart_obj.flush(); | |||
There was a problem hiding this comment.
Calling resize() here would blow away the size set in the constructor, so I've replaced the call with flush(), which forces a redraw. The 500-ms delay seems to have been unnecessary.
|
On Android. Before:
After:
|
|
I noticed that the "Latest Scan" text butts up against the telemetry table. One or the other might need a margin set.
|
argilo
force-pushed
the
reduce-scan-size
branch
from
0b591b7 to
65d895f
Compare
|
I added a 0.25em margin above and below the telemetry table, which keeps it separated from tasking section & scan plot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scan plot takes up quite a lot of precious vertical space. Here I've made it smaller by removing the "Scan Results" heading, reducing the vertical size from 320 pixels (the default) to 200 pixels, and removing the legend.
Before:
After: