add sed for systemd service #611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add sed so that the username is *automatically set* in `auto_rx.service` Admitting the script is run by the right user (not as root) I just tested and it worked fine for me
|
It should be merged in my opinion ! |
pinkavaj
reviewed
Aug 18, 2024
| @@ -82,4 +82,7 @@ cp ../demod/mod/meisei100mod . | |||
| cp ../demod/mod/imet54mod . | |||
| cp ../demod/mod/mp3h1mod . | |||
|
|
|||
| # Match user name in systemd service: no more need to use a text editor | |||
| sed -i "s/pi/$(whoami)/g" auto_rx.service | |||
There was a problem hiding this comment.
IMHO the Specifiers should be used here %h specifically
https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html#Specifiers
to make it more generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sed so that the username is automatically set in
auto_rx.serviceAdmitting the script is run by the right user (not as root)
I just tested and it worked fine for me