Fix Android/ARM build support #5848
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @noob6t5 ! |
dwisiswant0
reviewed
Nov 26, 2024
Comment on lines
+29
to
+34
| ifneq ($(shell go env GOARCH), arm) | ||
| GOARCH=arm | ||
| endif | ||
| ifneq ($(shell go env GOOS), android) | ||
| GOOS=android | ||
| endif |
There was a problem hiding this comment.
This doesn’t affect anything, you’re not overwriting anything for the build.
There was a problem hiding this comment.
My bad, I thought it was an ifeq expression.
If that’s the case, it’ll force the build for the android regardless of the current OS & arch env, which will break the entire workflow.
There was a problem hiding this comment.
I think it won't break
Please Can you also take a look into it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In this PR I have make changes that let's
nucleito support running in android.Checklist