fix: update lib name to slippi_rust_extensions for Cargo 1.79 compat #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikhilNarayana
requested changes
Aug 8, 2024
There was a problem hiding this comment.
this works as expected, however the changes to SlippiRustExtensions should be PR'd in https://github.com/project-slippi/slippi-rust-extensions and this repo's PR should update to the latest commit in main once the former is merged
Have now submitted the PR to the submodule upstream. I will update the commit here once it's merged |
NikhilNarayana
force-pushed
the
pascal-lib-name-change
branch
from
acdc2fb to
2132407
Compare
NikhilNarayana
approved these changes
Sep 17, 2024
NikhilNarayana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo 1.79 breaks Linux build by replacing dashes with underscores in
cargo metadatacausing corrosion to generate incorrect lib names in CMake files before corrosion v0.5.0.This just changes the lib name to use underscores instead of dashes to avoid any confusion.