Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Custom Rules on Direct & Teams #278

Open
wants to merge 13 commits into
base: slippi
Choose a base branch
from

Conversation

rapito
Copy link
Contributor

@rapito rapito commented May 9, 2021

Features

Adds ability to create Custom Ruleset Games on Direct and Teams Modes

  • Added Custom Rules Button
  • Initialized Custom Rules text based on ruleset (disappears when connected and shows "playing {opponent}")
  • Added a Quick Reset button to restore Default Ruleset (Press Z on Custom Rules Menu)
  • Adds in-game Text to indicate if current game has Custom Rules.
  • Random Stage is obtained from the game if on Direct/Teams and Custom Rules is set instead of Dolphin.

Changes

  • Added toggleable option to turn off custom rules.
  • Updated MatchSelections to include attributes necessary for match info syncing.
  • Receive Random Stages with Match Selections and Added it to the Online Match State buffer to allow stage select syncing.
  • Moved default MatchBlock to a vector on header files. Any non custom game will use this.
  • Parse player selections on prepare online match state to indicate all players are in sync before starting a match.
  • Only use dolphin's random stages if required by the game mode or player's settings.
  • Only override pause bitfield if necessary on prepare match state.
  • Removed panic dialogs from Vulkan (OSX Only) (Any errors are still logged)
  • Removed White bg on OSX Dolphin's log window. Set it to black as everything else, now I can actually read it.

Preview

slippi config pane option

image

in-game text

image

Reset Ruleset Button (might change it to make it look similar to UI's on name Entry)

image

Working Demo Video

pe.mov

@rapito
Copy link
Contributor Author

rapito commented Sep 8, 2021

  • Merged with upstream
  • Added changes requested by Fizzi so only the decider can set custom rules.

Also make sure to set "is custom rules" when both allowance and custom ruleset are present
@rapito
Copy link
Contributor Author

rapito commented Sep 9, 2021

  • Fixed bug where decider could join in match with custom rules while opponent had custom rules disabled on their instance
  • Validate packets for incoming player selections (for custom rules related attributes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant