Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty ICAC in AddNocReq - Fixes #216 #218

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Handle empty ICAC in AddNocReq - Fixes #216 #218

merged 1 commit into from
Dec 1, 2024

Conversation

3wnbr1
Copy link
Contributor

@3wnbr1 3wnbr1 commented Dec 1, 2024

Fixes #216 with improved handling of empty ICAC in AddNocReq

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Dec 1, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  rs-matter/src/data_model/sdm/noc.rs  49% smaller

@ivmarkov ivmarkov merged commit ccf1c1a into project-chip:main Dec 1, 2024
3 of 12 checks passed
@ivmarkov
Copy link
Contributor

ivmarkov commented Dec 1, 2024

@3wnbr1 Note that CI fails because #215 is not applied yet - we need @kedars to approve it (as I authored it, and therefore I cannot self-approve :) )

@3wnbr1 3wnbr1 deleted the handle-empty-icac branch December 1, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivmarkov ivmarkov ivmarkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improper handling of optional ICAC in AddNocReq resulting in crash
2 participants
@3wnbr1 @ivmarkov