Add logValue Method for Range Inputs to p5.Element #7246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented a method called logValue on p5.Element prototype for <input type="range"> elements - Allows slider values to be mapped to a logarithmic scale between min and max - Ensures that values reach exactly min at the lowest and max at the highest positions - Useful for applications such as audio volume control, brightness, and other parameters requiring logarithmic scaling
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
|
is this based on some issue? I am curious why we add this directly to the element and not create mapping functionality / utillity to the logarithmic domain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR introduces a new method, logValue, to the p5.Element prototype for range () elements. This method allows users to map slider values logarithmically, which is particularly useful for applications like audio volume control, where perception of changes follows a logarithmic rather than linear scale.
Changed files are: src/dom/dom.js and test/unit/dom/dom.js
Screenshots of the change:
PR Checklist
npm run lintpasses