Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Banner): Remove the CSS modules feature flag from Banner #5282

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

chore(Banner): Remove the CSS modules feature flag from Banner #5282

wants to merge 5 commits into from

Conversation

jonrohan
Copy link
Member

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from Banner

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner November 13, 2024 22:59
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: fc2735c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Nov 13, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5282 November 13, 2024 23:01 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 99.33 KB (0%)
packages/react/dist/browser.umd.js 99.67 KB (0%)

@jonrohan jonrohan requested review from randall-krauskopf and removed request for camertron November 13, 2024 23:02
@github-actions github-actions bot temporarily deployed to storybook-preview-5282 November 14, 2024 00:25 Inactive
francinelucca
francinelucca reviewed Nov 14, 2024
View reviewed changes
packages/react/src/Banner/Banner.test.tsx
@@ -115,9 +115,9 @@ describe('Banner', () => {
/>,
)

expect(screen.getByRole('button', {name: 'test primary action'})).toBeInTheDocument()
expect(screen.queryAllByText('test primary action')[0]).toBeInTheDocument()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this because the tests where failing? If so maybe we should run integration tests to make sure it doesn't happen in dotcom

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For responsiveness we're rendering 2 elements now. I couldn't figure out if I could only getByRole for visible ones so I ended updating to get the first result

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the jest tests couldn't differentiate between seen and not seen 🤔 will most likely need to fix tests in dotcom when this one lands

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make the change in dotcom now so it doesn't break the release? We've been trying to do that if possible. If not, can we have the changes ready to go in a commit so that they can be cherry-picked into the release branch?

@github-actions github-actions bot temporarily deployed to storybook-preview-5282 November 14, 2024 16:28 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351263

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 14, 2024
@jonrohan jonrohan marked this pull request as draft November 14, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca left review comments

@randall-krauskopf randall-krauskopf Awaiting requested review from randall-krauskopf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @francinelucca