Modules/docker #49

akarzim · 2017-03-04T23:33:24Z

Add some concise aliases for docker, docker-machine and docker-compose.

AFAIK, theses aliases will not shadow other system commands or prezto’s module aliases.

paulmelnikow · 2017-03-05T16:06:00Z

For the record: this is a repost of sorin-ionescu#1147

malikoth · 2017-03-07T19:46:40Z

Exciting!

paulmelnikow · 2017-03-07T22:14:24Z

modules/docker/README.md

+
+[1]: https://www.docker.com/
+[2]: https://github.com/zplug/zplug
+[3]: https://github.com/akarzim/zsh-docker-aliases/issues


This seems a bit confusing. We've started some discussions (see #38 and #33) about these blocks.

I'd like this to read something like this:

Support

If you're having problems, use the Prezto issue tracker.

Acknowledgements

This module is a copy of akarzim/zsh-docker-aliases by François Vantomme (MIT License).

cc @johnpneumann @cottser who have been part of those discussions

@paulmelnikow 👍 that makes sense to me, seems like a good way to acknowledge the origin of the code without signing them up to support it :)

Thanks for the feedback. I agree with this. Changes are done ;)

paulmelnikow · 2017-03-07T22:21:10Z

I don't want to set a precedent for adding lots of new modules. However Docker is widely used, so I'd like to include it in Prezto.

I'm interested to hear what other people think.

malikoth · 2017-03-07T23:16:06Z

I'm very much in favor of including this. Docker seems to have swept the world, and it would be nice to have this module maintained to make it easier and faster to work with Docker.

paulmelnikow · 2017-03-08T13:09:49Z

Looks good to me.

maximbaz · 2017-03-14T09:32:45Z

I don't want to set a precedent for adding lots of new modules.

@paulmelnikow why not? #52 might take quite a long time, why prevent adding new modules until it's done? When #52 is ready, all the external plugins will likely be purged anyway.

paulmelnikow · 2017-03-27T00:11:39Z

Just a heads up that reviewing and merging are on pause because Sorin is open to adding maintainers to the original (#44).

This fixes a security issue with malicious branch names

Homebrew decided to not change the behaviour of `brew upgrade` so `brew upgrade --all` is equivalent to `brew upgrade` without any other arguments (so the `--all` is a no-op and can be removed).

)

…rin-ionescu#598) * Support skip-virtualenvwrapper-init zstyle in python module to avoid auto-sourcing of virtualenvwrapper.sh * Don't overwrite the WORKON_HOME env var if the user has already set it

paulmelnikow · 2017-04-04T15:29:51Z

@belak has started merging changes at the original. I sincerely hope this is merged! It looks like the original PR now needs to be rebased, as it seems to be tracking the same branch as this one.

Think the simplest thing would be to make a new branch, and a new PR at the original.

This commit changes the way $TMPDIR is set by using `mktemp` rather than a fixed string.

- Implementation from sorin-ionescu#1001 - Documentation from sorin-ionescu#1178

…#1124)

Multiplexer titles can be set independent of window and tab titles. Add auto-title always option to have dynamic titling inside terminal multiplexers. Setting auto-title to yes continues to ignore dynamic titling inside terminal multiplexers. This patch should not alter behavior under Apple terminals.

The new call is compatible with colordiff v1.0.8 - v.1.0.15 (might be compatible with even earlier versions, but not tested), while the original one breaks down under v1.0.14 and v1.0.15. See daveewart/colordiff#22.

…s-context-config Adds additional support for PS prompt context expansion

belak · 2017-04-13T09:16:22Z

There's a bit of discussion that I'd like to see in the new PR before it gets merged... things like what aliases are worth including and how they should be organized. In short, I feel like the prezto git module aliases get a bunch of things right and I'd like to see a similar structure with the docker aliases. Anyway, discussion at the new PR (and it looks like this has been rebased against the original prezto to make that PR work), so this can probably be closed.

See sorin-ionescu#1147

7 is pretty arbitrarily chosen, but seems like a reasonable tradeoff, at least the completion no longer shows symptoms of exponential time-growth when trying to complete something completely wrong. This fixes sorin-ionescu#946.

Closes sorin-ionescu#955

@jeffwidman

Thanks to @jeffwidman for pointing this out Closes sorin-ionescu#1141

@malikoth

Thanks to @malikoth and @saoula for their input.

Fixes sorin-ionescu#1037

paulmelnikow · 2017-04-14T17:55:42Z

Merged via sorin-ionescu#1147.

paulmelnikow added the enhancement label Mar 5, 2017

paulmelnikow suggested changes Mar 7, 2017

View reviewed changes

paulmelnikow approved these changes Mar 8, 2017

View reviewed changes

malikoth mentioned this pull request Mar 8, 2017

Define the goals of this fork #44

Open

johnpneumann and others added 8 commits April 2, 2017 14:09

Adds additional support for PS prompt context expansion

b38ced8

Allow setting ZPREZTODIR to make prezto easier to integrate with

7346efd

Set ZPREZTODIR to ${0:h}

0be0ff5

Update pure prompt to v1.5.2

8820b71

This fixes a security issue with malicious branch names

update brewu method

2ba060a

Homebrew decided to not change the behaviour of `brew upgrade` so `brew upgrade --all` is equivalent to `brew upgrade` without any other arguments (so the `--all` is a no-op and can be removed).

Use python3 for http-serve alias if available (sorin-ionescu#1193)

8913bcc

Ensure code blocks are formatted properly for GitHub (sorin-ionescu#1271

5271af8

)

Add support for skipping VIRTUALENVWRAPPER init in modules/python (so…

a772956

…rin-ionescu#598) * Support skip-virtualenvwrapper-init zstyle in python module to avoid auto-sourcing of virtualenvwrapper.sh * Don't overwrite the WORKON_HOME env var if the user has already set it

paulmelnikow and others added 10 commits April 4, 2017 08:46

Don't load pfunctions from vi swap files

dcd8596

Change $TMPDIR for non-interactive shells

3a6ae0f

This commit changes the way $TMPDIR is set by using `mktemp` rather than a fixed string.

Add "sa" alias to make it easy to search aliases

4e35f70

Avoid unsetting nonexistent variables (sorin-ionescu#1075)

2c1ad5b

Add nodenv support to Node.js module

4834470

- Implementation from sorin-ionescu#1001 - Documentation from sorin-ionescu#1178

Prefer $(COMMAND) syntax over backticks (sorin-ionescu#1012)

fb68944

Remove extra use of grep in git-hub-shorten-url (sorin-ionescu#904)

12d48df

Add notice about potential shadowing of the gb command (sorin-ionescu…

65b05c0

…#1124)

Use less destructive git push --force-with-lease.

ddfc870

utility module: fix/improve colordiff call in diff

464a8d2

The new call is compatible with colordiff v1.0.8 - v.1.0.15 (might be compatible with even earlier versions, but not tested), while the original one breaks down under v1.0.14 and v1.0.15. See daveewart/colordiff#22.

akarzim force-pushed the modules/docker branch 2 times, most recently from e3fedfd to ce88def Compare April 5, 2017 07:51

paulmelnikow and others added 11 commits April 5, 2017 09:34

Bump license years and tidy up readme (sorin-ionescu#1273)

9090066

Add support for iTerm2 v3 in tab function

e413ef5

Use patterns from ruby module for initializing nodenv

8dafaae

Fix path in node module

94708f6

Merge pull request sorin-ionescu#1272 from sorin-ionescu/issue/1246-p…

412af29

…s-context-config Adds additional support for PS prompt context expansion

FIXED: syntax error in osx module tab function

ee249e5

Only try to run python-info if it exists for the paradox prompt

b963484

Move common promptpwd code to external function

60c433d

Ensure extendedglob is set in promptpwd

8655cd5

Remove manb from completion filename

9a70a16

Update fasd README with basic installation information

95036c9

akarzim and others added 10 commits April 13, 2017 02:23

Feat (aliases): add aliases for git flow

fb6f3f7

Allow syntax highlighting pattern styles (sorin-ionescu#1192)

1c0f95c

Add note about working around preexisting runcoms

2e20eb8

Closes sorin-ionescu#955

Don't use a deprecated argument as a python example

7011031

Thanks to @jeffwidman for pointing this out Closes sorin-ionescu#1141

Add bundle clean alias

7c64584

Doc (ruby): add doc on bundle clean alias

bb168c5

Feat (docker): add docker aliases (sorin-ionescu#1147)

8a43331

Thanks to @malikoth and @saoula for their input.

Fix indentation in README

d035e4c

Update is-callable to also check builtins

e606b09

Fixes sorin-ionescu#1037

akarzim force-pushed the modules/docker branch 2 times, most recently from 2cc1bf5 to e606b09 Compare April 13, 2017 14:23

paulmelnikow closed this Apr 14, 2017

akarzim deleted the modules/docker branch March 31, 2018 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modules/docker #49

Modules/docker #49

akarzim commented Mar 4, 2017 •

edited

Loading

paulmelnikow commented Mar 5, 2017

malikoth commented Mar 7, 2017

paulmelnikow Mar 7, 2017

star-szr Mar 8, 2017

akarzim Mar 8, 2017

paulmelnikow commented Mar 7, 2017

malikoth commented Mar 7, 2017

paulmelnikow commented Mar 8, 2017

maximbaz commented Mar 14, 2017

paulmelnikow commented Mar 27, 2017

paulmelnikow commented Apr 4, 2017

belak commented Apr 13, 2017 •

edited

Loading

paulmelnikow commented Apr 14, 2017

Modules/docker #49

Modules/docker #49

Conversation

akarzim commented Mar 4, 2017 • edited Loading

paulmelnikow commented Mar 5, 2017

malikoth commented Mar 7, 2017

paulmelnikow Mar 7, 2017

Choose a reason for hiding this comment

Support

Acknowledgements

star-szr Mar 8, 2017

Choose a reason for hiding this comment

akarzim Mar 8, 2017

Choose a reason for hiding this comment

paulmelnikow commented Mar 7, 2017

malikoth commented Mar 7, 2017

paulmelnikow commented Mar 8, 2017

maximbaz commented Mar 14, 2017

paulmelnikow commented Mar 27, 2017

paulmelnikow commented Apr 4, 2017

belak commented Apr 13, 2017 • edited Loading

paulmelnikow commented Apr 14, 2017

akarzim commented Mar 4, 2017 •

edited

Loading

belak commented Apr 13, 2017 •

edited

Loading