Improve Pyramid location documentaion #2073
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, actually with the new semantics of if (InBattlePyramid() == 2)they'll get surprising results. I'd personally rather have an error pointing me to the new name. |
|
Good point. |
|
Applied :) |
Comment on lines
+93
to
+95
| if (CurrentBattlePyramidLocation() != PYRAMID_LOCATION_NONE || InBattlePike() || InTrainerHillChallenge()) | ||
| #else | ||
| if (InBattlePyramid() | InBattlePike() || InTrainerHillChallenge()) | ||
| if (CurrentBattlePyramidLocation() | InBattlePike() || InTrainerHillChallenge()) |
There was a problem hiding this comment.
These should be the same, otherwise it looks like the difference is significant for the bug fix (I guess in some sense it is, but then it's much easier to miss the | vs ||)
| if (!InBattlePyramid()) | ||
| if (CurrentBattlePyramidLocation() == PYRAMID_LOCATION_NONE) // CurrentBattlePyramidLocation() == PYRAMID_LOCATION_NONE doesn't match |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
InBattlePyramidname was a bit of a misnomer, as it could return 0, 1 or 2 instead of just 0 and 1.Added an in-line function with the original name to reduce verboseness and potential downstream conflicts.
Discord contact info
AsparagusEduardo