Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recorded battle link player loops #2071

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix recorded battle link player loops #2071

merged 2 commits into from
Dec 4, 2024

Conversation

AsparagusEduardo
Copy link
Contributor

Description

2 for loops used MAX_BATTLERS_COUNT instead of MAX_LINK_PLAYERS, which causes potential errors when MAX_BATTLERS_COUNT is increased.

Discord contact info

AsparagusEduardo

@GriffinRichards
Copy link
Member

These loops are iterating over other arrays that also use MAX_BATTLERS_COUNT, if the loops are updated the arrays should be updated to match.

@AsparagusEduardo
Copy link
Contributor Author

These loops are iterating over other arrays that also use MAX_BATTLERS_COUNT, if the loops are updated the arrays should be updated to match.

Done 👍

@GriffinRichards GriffinRichards merged commit e605ffb into pret:master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsparagusEduardo @GriffinRichards