Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format object event graphics info #1643

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

cbt6
Copy link
Contributor

@cbt6 cbt6 commented Mar 12, 2022

Description

Discord contact info

cbt#8922

@GriffinRichards GriffinRichards marked this pull request as draft March 12, 2022 21:24
@GriffinRichards
Copy link
Member

Please see #1554

@mrgriffin
Copy link
Collaborator

mrgriffin commented Aug 16, 2022

Note to self: I assume Porymap can't handle macros, but it would be nice if size, width, height, and potentially subspriteTables were derived from oam (although note that the truck has 48x48 subsprite table but a 32x32 oam), or everything could be derived from some other data. It'd also be handy if the -mwidth and -mheight of the gbagfx command could be derived from the width and height.

@GriffinRichards
Copy link
Member

@mrgriffin If you are interested in doing that for your repo, here's a full list of dimension disagreements (had to find these anyway):

Object width/height subspriteTables oam
SS Tidal 96x40 96x40 8x8
Submarine Shadow 88x32 88x32 8x8
Truck 48x48 48x48 32x32
Berry Tree 16x16 NULL 16x16
Town Map (FRLG) 32x16 16x16 32x16
SS Anne (FRLG) 128x64 128x64 8x8

Additionally, all the "Normal" player avatar objects are 16x32 but have a size of 512, and BerryTree and BerryTreeEarlyStages are 16x16 but have a size of 256.

@GriffinRichards GriffinRichards changed the base branch from master to porymap-5 September 26, 2022 01:55
@GriffinRichards GriffinRichards marked this pull request as ready for review September 26, 2022 01:55
@GriffinRichards GriffinRichards merged commit 171367d into pret:porymap-5 Sep 26, 2022
@cbt6 cbt6 deleted the object-event-graphics-info branch September 26, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants