Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build artifacts to build/ #1226

Closed
wants to merge 1 commit into from

Conversation

ExpoSeed
Copy link
Contributor

@ExpoSeed ExpoSeed commented Oct 6, 2020

Description

Move remaining build artifacts to build/. Resolves #1224.

Discord contact info

ExpoSeed#2020

@ExpoSeed ExpoSeed changed the title Move midi .s files to build/ Move build artifacts to build/ Oct 6, 2020
LOuroboros pushed a commit to LOuroboros/pokeemerald that referenced this pull request Nov 18, 2020
ifdef items in base_stats.h and uncomment vanilla hold items
@ExpoSeed
Copy link
Contributor Author

should probably state this here, i'm no longer working on this because it's far too out of my depth (i'm an amateur at makefile)

one issue of note to resolve is that changing the location of generated files renders the majority of incbins incorrect

@GriffinRichards
Copy link
Member

Closing because you don't plan to work on it. Can always be reopened if you change your mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some build artifacts are not in build/
2 participants