Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI (obsolete lockfile) #431

Open
wants to merge 1 commit into
base: react-1.2.x
Choose a base branch
from
Open

Fix CI (obsolete lockfile) #431

wants to merge 1 commit into from

Conversation

XantreDev
Copy link
Contributor

@XantreDev XantreDev commented Nov 5, 2023 •
edited
Loading

Updated lockfile to fix CI

Partially based on #391

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 94b7768

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@XantreDev XantreDev mentioned this pull request Nov 5, 2023
Closed
@XantreDev XantreDev force-pushed the react-1.2.x-update-lockfile branch 3 times, most recently from 73d851a to 78aa455 Compare November 6, 2023 07:58
@XantreDev
Copy link
Contributor Author

@robertknight I've added ci for target branch

rschristian
rschristian previously requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be targetting main, not the one-off branch (that I'm still not sure we'll support a release for). Everything in the workflow files looks like it should be reverted.

.github/workflows/compressed-size.yml Outdated Show resolved Hide resolved
@rschristian
Copy link
Member

Correct me if I'm wrong, but looks like this might've already been done?

signals/pnpm-lock.yaml

Line 1 in e046714

lockfileVersion: '6.0'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian Awaiting requested review from rschristian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XantreDev @rschristian