Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rounding corners in wbarstylegen.sh #2023

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rishav12s
Copy link
Contributor

Pull Request

Description

Please read these instructions and remove unnecessary text.

  • Fixes the rounding corners when rounding is commented out in hypr.theme

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Nov 28, 2024

Did you test this?

I'm using a fork so maybe I'm doing something different

@rishav12s
Copy link
Contributor Author

switching from a commented rounding theme to rounding theme makes waybar 0 round

ig it needs improvement/changes will have to check

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Nov 28, 2024

race conditions, that's why we needed to parse the hypr.theme.


hypr_border=$(awk -F '=' '{if($1~" rounding ") print $2}' $src_file | sed 's/ //g')
 if [ "$hypr_border" == "0"  ] || [ -z "$hypr_border" ] ; then 
     sed -i "/border-radius: /c\    border-radius: 0px;" "$out_file" 
  fi

Try this one

@rishav12s
Copy link
Contributor Author

race conditions, that's why we needed to parse the hypr.theme.


hypr_border=$(awk -F '=' '{if($1~" rounding ") print $2}' $src_file | sed 's/ //g')
 if [ "$hypr_border" == "0"  ] || [ -z "$hypr_border" ] ; then 
     sed -i "/border-radius: /c\    border-radius: 0px;" "$out_file" 
  fi

Try this one

this one works but i think the default one was good with waybar not rounding when commenting out rounding in hypr.theme
if we can have seperate rounding variables in waybar and rofi .theme then it be better (if rounding not mentioned in them then follow hypr.theme)
and as wlogout follows waybar theming it would also follow that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants