Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyprlock + Hypridle #1885

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Hyprlock + Hypridle #1885

wants to merge 7 commits into from

Conversation

abenezerw
Copy link
Contributor

@abenezerw abenezerw commented Sep 25, 2024

Re-work of Khings original PR #1173

+ All 3 layouts done ✅
+ Dynamic wallpaper same as background ✅
+ Dynamic color accents same as theme ✅
+ Restructured a few modules and cleaned them ✅

+ Positioned them like this on purpose for layout 1 because I have the same style and colors for sddm config, 
for a pr after this.
+ sddm config also added ✅
+ need to work on user avatar for sddm though

Layout 1

layout1tt3
layout1ttt
layout1tttt
layout11212
layouttt

Layout 3

333
3333
333333

Layout 2

22
222
2

SDDM configs

sddm

Re-work of Khings original PR prasanthrangan#1173
@rubiin
Copy link
Contributor

rubiin commented Sep 29, 2024

@abenezerw
Copy link
Contributor Author

@abenezerw check these out https://github.com/MrVivekRajan/Hyprlock-Styles

I saw them. But just wanted something simple for the default lock screen. Of course people who are config savvy can swap out their lockscreen. And would probably have already. I’m just doing this for the average people out there who blindly install arch and hyprdots just cause it looks cool. 😎😂

@rubiin
Copy link
Contributor

rubiin commented Oct 23, 2024

@kRHYME7 any update on this one. Looks like this can be merged.

@Kai-Johnstone
Copy link

Kai-Johnstone commented Oct 25, 2024

@kRHYME7 any update on this one. Looks like this can be merged.

@rubiin, @abenezerw i know im not him but from using this config here's what i know needs to be changed so far:
keybindings.conf needs the line bindl = ,switch:Lid Switch, exec, hyprlock (also needs to change the default lock bind to use hyprlock instead of swaylock) and the wlogout layouts need to be fixed.

@zeerayne
Copy link
Contributor

zeerayne commented Nov 3, 2024

I have merged this to my fork and perform some testing and want to share my suggestions:

/Configs/.config/hypr/keybindings.conf:

-bind = $mainMod, L, exec, swaylock # launch lock screen
+bind = $mainMod, L, exec, hyprlock # launch lock screen

/Scripts/restore_fnt.lst

+Font_Anurati|$HOME/.local/share/fonts

/Scripts/custom_hypr.lst

-swaylock-effects-git
+hypridle
+hyprlock

@rubiin
Copy link
Contributor

rubiin commented Nov 3, 2024

Do share here of you came across anything that is lagging or needs tweaking

@abenezerw
Copy link
Contributor Author

I have merged this to my fork and perform some testing and want to share my suggestions:

/Configs/.config/hypr/keybindings.conf:

-bind = $mainMod, L, exec, swaylock # launch lock screen
+bind = $mainMod, L, exec, hyprlock # launch lock screen

/Scripts/restore_fnt.lst

+Font_Anurati|$HOME/.local/share/fonts

/Scripts/custom_hypr.lst

-swaylock-effects-git
+hypridle
+hyprlock

Done, Done and Done. Thanks.

@zeerayne
Copy link
Contributor

zeerayne commented Nov 4, 2024

I have some additional thoughts, want to discuss it here:

  1. Hyprdots keyboard switch is not compatible with any screenlock (hyprlock/swaylock), to fix this input.kb_options should be used to switch keyboard layout. Using kb_options allow you to switch layout on lockscreen, otherwise you are stuck and unable to input password correctly.

    Example:

    input {
        kb_options = grp:win_space_toggle
    }
    
  2. Hyprlock layouts do not show current keyboard layout, which can be confusing, maybe to add display of layout if it is other, than default one?

    Example:

    # Keyboard layout
    label {
        monitor =
        text = $LAYOUT[!]
        color = $p4_accent_9_rgba
        font_size = 14
        font_family = $font_family Medium
        position = 30, 30
        halign = left
        valign = bottom
    }
    

@zeerayne
Copy link
Contributor

One suggestion here for layout3:

/Configs/.config/hypr/hyprlock/presets/layout3.conf:

-text = cmd[update:1000] echo "$(date +"%A")"   
+text = cmd[update:1000] date +"%A" | awk '{ print toupper($0) }'

After this change Anurati font will apply for all letters, noy only for first. Looks like this font contains only capital letters.

@abenezerw
Copy link
Contributor Author

One suggestion here for layout3:

/Configs/.config/hypr/hyprlock/presets/layout3.conf:

-text = cmd[update:1000] echo "$(date +"%A")"   
+text = cmd[update:1000] date +"%A" | awk '{ print toupper($0) }'

After this change Anurati font will apply for all letters, noy only for first. Looks like this font contains only capital letters.

good catch. i forgot about this one. basically just set it all up locally and forgot about this pr.

@abenezerw
Copy link
Contributor Author

I have some additional thoughts, want to discuss it here:

1. Hyprdots keyboard switch is not compatible with any screenlock (hyprlock/swaylock), to fix this `input.kb_options` should be used to switch keyboard layout. Using `kb_options` allow you to switch layout on lockscreen, otherwise you are stuck and unable to input password correctly.
   Example:
   ```
   input {
       kb_options = grp:win_space_toggle
   }
   ```

2. Hyprlock layouts do not show current keyboard layout, which can be confusing, maybe to add display of layout if it is other, than default one?
   Example:
   ```
   # Keyboard layout
   label {
       monitor =
       text = $LAYOUT[!]
       color = $p4_accent_9_rgba
       font_size = 14
       font_family = $font_family Medium
       position = 30, 30
       halign = left
       valign = bottom
   }
   ```

and lets hold off on this one until/if this gets merged.
its already getting beefy. just want to have the basics first

@rubiin
Copy link
Contributor

rubiin commented Nov 14, 2024

@abenezerw any thing left to update ?

@abenezerw
Copy link
Contributor Author

@abenezerw any thing left to update ?

i dont think so. even if anything is left. i think they can be updated with extra prs. this is just the bare minimum.

@rubiin
Copy link
Contributor

rubiin commented Nov 14, 2024

@kRHYME7 LGTM. Its been on review for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants